I've reworked SO many systems that started clean and were obviously updated by a series of different people over a span of years. New features nailed on with apparently little understanding of the overall app. It's like, "Oh dude it was already doing 90% of what you wanted, you didn't have to add all this... ." Especially true when offshore contract agencies had been involved - to churn through jobs as fast as possible (with no other concern) they tend to copypaste sections of the app that do something similar to what's desired, and make minimal changes to them, with zero code cleanup. This leaves all sorts of misleading unnecessary code, as well as inefficiencies like grabbing a large dataset to get a single item, etc. I found things that made me literally LOL.

[–] chunkystyles@sopuli.xyz 1 points 2 minutes ago

Our off shore contractors produce some of the worst code. But it's impossible to get work done and also be vigilant enough to reject their bad pull requests. So basically you'll end up looking a code one day that is godawful and think, "this is off shore". And yep, git blame tells you you're right.

[–] JackbyDev@programming.dev 21 points 8 hours ago (2 children)

I feel line this would be funnier as "code updated to do 999 things"

[–] fulner@social.mojo.fyi 1 points 2 hours ago

@JackbyDev lol

[–] LovableSidekick@lemmy.world 3 points 4 hours ago

Excellent point. Sometimes removing functionality is much more kludgy than adding it.

[–] dumnezero@piefed.social 38 points 12 hours ago (1 children)

Shoutout to !fuckcars@lemmy.world

[–] QuazarOmega@lemy.lol 24 points 10 hours ago (2 children)

I'm disappointed that I misunderstood the topic of that community

[–] xmunk@sh.itjust.works 14 points 8 hours ago

Oh, you must be looking for dragonsfuckingcars.

[–] ByteJunk@lemmy.world 3 points 8 hours ago

I exhaled vigorously through my nose.

[–] fsxylo@sh.itjust.works 4 points 11 hours ago

Single responsibility principal and dependency injection are your friends.