In recent years I've gotten a couple 8BitDo controllers that I love.
As a kid though I think I had one Wildcat controller for the N64 that I felt was lucky, but besides that I was never even aware of what brand my controllers were, it was just whatever you could convince your parents to buy you.