Looks good! Although I went looking for a comparison to circadian (which is what I use) in the README and didn't see it. Were you aware of it before writing your own package?
Emacs
A community for the timeless and infinitely powerful editor. Want to see what Emacs is capable of?!
Get Emacs
Rules
- Posts should be emacs related
- Be kind please
- Yes, we already know: Google results for "emacs" and "vi" link to each other. We good.
Emacs Resources
Emacs Tutorials
- Beginner’s Guide to Emacs
- Absolute Beginner's Guide to Emacs
- How to Learn Emacs: A Hand-drawn One-pager for Beginners
Useful Emacs configuration files and distributions
Quick pain-saver tip
Not exactly what you asked, but take a look at https://github.com/LionyxML/auto-dark-emacs
It follows your system settings, only for dark/light modes. Available on melpa and works with Linux, macOS, Windows and Android(via termux).
Reviewed the code, great job on your first package—wouldn't know it was your first if you hadn't said so! I think you should definitely get it on MELPA.
If you wanted a next step for it, you could consider giving users not just the option of set times, but:
- tying it into the OS dark/light schedule
- or tying into Emacs'
solar
functions to get their local sunrise/sunset times - or making an API call to get local sunrise/sunset times.
You could also give them an option to provide an offset to those times... maybe they want light theme 30 minutes after the sun rises and dark theme 45 minutes before the sun sets, for example.
I did some thinking on this because I wanted to write a similar package at some point, before realizing I actually didn't want to switch themes at all. : )
No matter where you go with this, congrats on your first package. Well done!