this post was submitted on 18 Jan 2024
243 points (96.6% liked)

Programmer Humor

19557 readers
864 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
243
DO NOT MERGE (feddit.dk)
submitted 10 months ago by leds@feddit.dk to c/programmer_humor@programming.dev
33 comments fedilink hide all child comments
 

Merged

you are viewing a single comment's thread
view the rest of the comments
[–] aMockTie@beehaw.org 21 points 10 months ago (3 children)

Why did they submit this as a pull request in the first place? Just commit it to a WIP branch until it’s ready to merge. Am I missing something?

[–] brisk@aussie.zone 30 points 10 months ago (1 children)

Probably to get some other benefitof the PR system, such as CI tests

[–] leds@feddit.dk 10 points 10 months ago (2 children)

Does gerrit have a draft state? In azure devops you can mark PR as draft , won't trigger any builds but you can still start them manually

[–] beeng@discuss.tchncs.de 4 points 10 months ago

manually

This is probably why the dev created a PR, less clicks

[–] sf1tzp@programming.dev 2 points 10 months ago

I don’t remember if it did when I used it. Our convention was to -2 your own change until it was ready to go 😅

[–] NotSteve_@lemmy.ca 7 points 10 months ago

I do this often. It's useful if you want to send it to your coworker for some early feedback or as others have said, have the CI run

[–] DrJenkem@lemmy.blugatch.tube 4 points 10 months ago* (last edited 10 months ago)

It's been a while since I've worked with AOSP, but I had always understood it to be some weird shit with Google's internal processes. The "do not merge" commits are all over the AOSP, or at least they used to be.