this post was submitted on 16 Nov 2023
317 points (98.8% liked)

Programmer Humor

19589 readers
544 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
317
me_irl (lemmy.eco.br)
submitted 1 year ago by pai_zosima@lemmy.eco.br to c/programmer_humor@programming.dev
30 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] catacomb@beehaw.org 1 points 1 year ago

To be honest, I agree they should be able to be larger at times.

I had a lot of disagreements when I was on a new codebase, knew what I was doing and I was able to push a lot of code out each day.

The idea is to have them small, easily readable with a tight feedback loop. I argued that bootstrapping a project will have a lot of new code at once to lay the foundations and my communication with the team was enough feedback. If I split it up, each PR would have been an incomplete idea and would have garnered a bunch of unnecessary questions.

That said, I think it's generally pretty easy to put out multiple PRs in a day, keeping them small and specific. As you say, half of the job is reading code and it's nicer to give my coworkers a set of PRs broken down into bite sized pieces.