this post was submitted on 29 Jul 2024
389 points (99.5% liked)
Programming
17432 readers
242 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
GitLab still doesn't even support leaving comments on a commit message. Like, what? GitLab and GitHub have all these fancy shiny features but still suck at offering basic code review functionality.
I never understood the appeal.
I mean, I get it, but that's also not a thing of git, right? Just because GitHub does something doesn't mean every other hosting provider needs to. If your code review process is to comment upon specific commits, maybe it's the code review process that's wrong?
Git kinda has it? Have you seen git notes? https://git-scm.com/docs/git-notes
GitHub doesn't let you comment on the commit message either. The only one I've seen do this properly this is Gerrit. And of course regular old mailing list reviews.
There are so many blogs and posts about writing good commit messages, using Conventional Commits, etc, and the two most popular forges don't even let you comment in-line on the commit message during a review.
You can leave comments on a commit message. What do you mean exactly?
You can not highlight text in a commit message and leave an in-line comment in the same way you can for code changes in the diff.
Edit: https://gitlab.com/gitlab-org/gitlab/-/issues/19691
Ohhhhh you can't comment on a specific line of a commit message. I see. I mean... yeah I guess not. That seems like a super niche feature though. How long are your commit messages? I've never even tried to do that. Commit messages are short enough you can pretty much just write a normal message not tied to a specific line.
There are waaaaay bigger issues with Gitlab. Here's one I ran into recently, you can't search for pipelines. It's got a search box and everything but you literally can't search; only filter. So stupid.
I actually just went to take a look at Gitlab issues I have commented on to see what my worst ones are. Guess what.... you can't even search for issues you have commented on!!!
Still, overall it's the best self-hostable option out there at the moment IMO. I guess Forgejo (truly abysmal name) may overtake it at some point.