this post was submitted on 18 Oct 2023
1 points (100.0% liked)

Emacs

313 readers
3 users here now

A community for the timeless and infinitely powerful editor. Want to see what Emacs is capable of?!

Get Emacs

Rules

  1. Posts should be emacs related
  2. Be kind please
  3. Yes, we already know: Google results for "emacs" and "vi" link to each other. We good.

Emacs Resources

Emacs Tutorials

Useful Emacs configuration files and distributions

Quick pain-saver tip

founded 1 year ago
MODERATORS
rglullis@communick.news
raphael@communick.news
1
opening magit full-frame then restoring windows on q (alien.top)
submitted 1 year ago by unduly-noted@alien.top to c/emacs@communick.news
9 comments fedilink hide all child comments
 

I'd like magit-status to open full frame, ie a single window. When I hit q to exit, I'd like my previous window configuration to be restored.

What's the best way to do this? Setting the follow var causes it to open full frame, but removes all windows except for one upon exit:

 (setq magit-display-buffer-function
  #'magit-display-buffer-fullframe-status-v1)

I can get to my previous window layout with winner-undo, but I'd like q to do the right thing in this case.

Any thoughts?

top 9 comments
sorted by: hot top controversial new old
[–] 404cn@alien.top 1 points 1 year ago

Install package fullframe then (fullframe magit-status magit-mode-quit-window)

​

Others: bind q to this function

​

```elisp

(defun eat/quit ()

"Delete current window switch to prevous buffer."

(interactive)

(if (> (seq-length (window-list (selected-frame))) 1)

(delete-window)

(previous-buffer)))

```

[–] abbreviatedman@alien.top 1 points 1 year ago

Might be able to do it with the hooks that run on entry and exit of the magit-status buffer? Save the window configuration on entry, reload it on exit?

[–] 7890yuiop@alien.top 1 points 1 year ago

I think you need to define your requirements in more detail. What if you call magit-status while using Magit? Does that change what the "previous window configuration" should be? (I suspect it does, in which case it's not going to be "the previous window configuration" that you want). If I'm correct, you should clarify exactly which window configuration you want to restore, and when (in which specific circumstances) that should be captured.

[–] fiverniner@alien.top 1 points 1 year ago (2 children)

u/unhammer commented this in another post that: https://www.reddit.com/r/emacs/comments/179t67l/window_management_share_your_displaybufferalist/k5b56i2/

(setq magit-display-buffer-function 'magit-display-buffer-fullframe-status-topleft-v1)
(setq magit-bury-buffer-function 'magit-restore-window-configuration)
[–] unduly-noted@alien.top 1 points 1 year ago

That's the ticket! Thank you!

[–] jvillasante@alien.top 1 points 1 year ago (1 children)

This configuration only buries the magit buffer which may or may not be what you want, I prefer to actually kill the buffer so this is what I use instead:

(use-package magit
    :preface (defun my/magit-kill-buffers ()
                 "Restore window configuration and kill all Magit buffers."
                 (interactive)
                 (let ((buffers (magit-mode-get-buffers)))
                     (magit-restore-window-configuration)
                     (mapc #'kill-buffer buffers)))
    :bind (:map magit-status-mode-map
                ("q" . #'my/magit-kill-buffers)
                ("C-x k" . #'my/magit-kill-buffers))
    :custom ((magit-display-buffer-function 'magit-display-buffer-same-window-except-diff-v1)
             (git-commit-summary-max-length 50)
             (magit-diff-refine-hunk t) ; show granular diffs in selected hunk.
             (magit-save-repository-buffers nil)
             (magit-define-global-key-bindings nil)))
[–] unduly-noted@alien.top 1 points 1 year ago (1 children)

Curious why you prefer killing?

[–] jvillasante@alien.top 1 points 1 year ago (1 children)

I just like to have a clean ibuffer :)

After done with magit I want all magit buffers killed so that I can have a clean buffer list.

[–] unduly-noted@alien.top 1 points 1 year ago

Makes sense. I tried to keep my buffer list clean at first, but kinda gave up cause so many things in emacs create buffers